Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override Kernel#warn when there is no need #4075

Merged
merged 3 commits into from Dec 7, 2020
Merged

Do not override Kernel#warn when there is no need #4075

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9124370
Do not override Kernel#warn when there is no need
eregon Nov 20, 2020
09726ae
Fix typo in Kernel#warn test
eregon Nov 20, 2020
1d8375b
module_eval + heredoc needs to use __LINE__ + 1 for correct line numbers
eregon Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rubygems/core_ext/kernel_require.rb
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ module Kernel
end

file = Gem::KERNEL_WARN_IGNORES_INTERNAL_ENTRIES ? "<internal:#{__FILE__}>" : __FILE__
module_eval <<'RUBY', file, __LINE__
module_eval <<'RUBY', file, __LINE__ + 1
deivid-rodriguez marked this conversation as resolved.
Show resolved Hide resolved
##
# When RubyGems is required, Kernel#require is replaced with our own which
# is capable of loading gems on demand.
Expand Down