Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override Kernel#warn when there is no need #4075

Merged

Commits on Dec 4, 2020

  1. Do not override Kernel#warn when there is no need

    * On Ruby implementations where https://bugs.ruby-lang.org/issues/17259
      is available, backtrace entries starting with `<internal:` are ignored
      for Kernel#warn. We can then define RubyGems's Kernel#require with
      such a filename and it will automatically be skipped for Kernel#warn.
    * This is much less fragile (overriding Kernel#warn causes multiple
      issues and is very difficult to do properly) and it is also more
      efficient (the override would walk the stack multiple times).
    eregon committed Dec 4, 2020
    Copy the full SHA
    9124370 View commit details
    Browse the repository at this point in the history
  2. Fix typo in Kernel#warn test

    eregon committed Dec 4, 2020
    Copy the full SHA
    09726ae View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    1d8375b View commit details
    Browse the repository at this point in the history