Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert resolving all Gemfile platforms automatically #4052

Merged
merged 1 commit into from Nov 10, 2020

Commits on Nov 6, 2020

  1. Revert resolving all Gemfile platforms automatically

    This is the second time I revert this change, since I have found some
    cases where this might cause pain, and I want to battle test
    multiplatform fixes before attempting this.
    
    I think ideally, when we introduce something like this, we should
    consider making it opt-in by recording this intention in the `Gemfile`,
    maybe with an unscoped `platforms` DSL, or by an explicit CLI flag, like `bundle
    install --all-platforms`, or `bundle lock --all-platforms`.
    
    The part I'm not reverting is removing the warning about dependencies
    being unused under the current platform, since it is pretty much
    expected on a multiplatform context.
    deivid-rodriguez committed Nov 6, 2020
    Copy the full SHA
    96d7b91 View commit details
    Browse the repository at this point in the history