Revert resolving all Gemfile platforms automatically #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the second time I revert this change, since I have found some cases where this might cause pain, and I want to battle test multiplatform fixes before attempting this. I think ideally, when we introduce something like this, we should consider making it opt-in by recording this intention in the `Gemfile`, maybe with an unscoped `platforms` DSL, or by an explicit CLI flag, like `bundle install --all-platforms`, or `bundle lock --all-platforms`. The part I'm not reverting is removing the warning about dependencies being unused under the current platform, since it is pretty much expected on a multiplatform context.
|
I will revisit this for the next version. |
deivid-rodriguez
added
bundler: skip changelog
bundler: enhancement
and removed
bundler: skip changelog
labels
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Revert resolving all Gemfile platforms automatically (cherry picked from commit a9b3694)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Revert resolving all Gemfile platforms automatically (cherry picked from commit a9b3694)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Revert resolving all Gemfile platforms automatically (cherry picked from commit a9b3694)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Revert resolving all Gemfile platforms automatically (cherry picked from commit a9b3694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
This is the second time I revert this change, since I have found some cases where this might cause pain, and I want to battle test multiplatform fixes before attempting this.
See #4018 for more on this.
What is your fix for the problem, implemented in this PR?
My fix is to revert resolving only for the current platform like it's been done historically.
I think ideally, when we introduce something like this, we should consider making it opt-in by recording this intention in the
Gemfile, maybe with an unscopedplatformsDSL, or by an explicit CLI flag, likebundle install --all-platforms, orbundle lock --all-platforms.The part I'm not reverting is removing the warning about dependencies being unused under the current platform, since it is pretty much expected on a multiplatform context.
Closes #4018.
Make sure he following tasks are checked