Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with cache_all_platforms and specific_platform configured #4042

Merged
merged 4 commits into from Oct 30, 2020

Commits on Oct 28, 2020

  1. Copy the full SHA
    cf5d93a View commit details
    Browse the repository at this point in the history
  2. Fix when having cache_all_platforms and specific_platform configured

    In this case, when running `bundle install`, bundler would be unable to
    find some gems when updating the cache.
    
    The reason is that the set of specs is initially materialized for the
    current platform for the standard `bundle install` behavior. But then
    when bundler tries to update the cache, the sources have that set of
    specs cached, and bundler is unable to find specs that are not for the
    current platform.
    
    The solution is to invalidate sources cache before materializing for all
    platforms, so that remote platform specific versions are considered.
    deivid-rodriguez committed Oct 28, 2020
    Copy the full SHA
    55f1cf1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fdb4282 View commit details
    Browse the repository at this point in the history
  4. Remove check that should no longer be necessary

    I think this was there to workaround multi platform issues that should
    now be fixed.
    deivid-rodriguez committed Oct 28, 2020
    Copy the full SHA
    934de94 View commit details
    Browse the repository at this point in the history