Fix issue with cache_all_platforms and specific_platform configured
#4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, when running `bundle install`, bundler would be unable to find some gems when updating the cache. The reason is that the set of specs is initially materialized for the current platform for the standard `bundle install` behavior. But then when bundler tries to update the cache, the sources have that set of specs cached, and bundler is unable to find specs that are not for the current platform. The solution is to invalidate sources cache before materializing for all platforms, so that remote platform specific versions are considered.
I think this was there to workaround multi platform issues that should now be fixed.
stevenharman
approved these changes
Oct 28, 2020
deivid-rodriguez
deleted the
another_cache_plus_specific_platform_issue
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…atform_issue Fix issue with `cache_all_platforms` and `specific_platform` configured (cherry picked from commit e0f6ce6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…atform_issue Fix issue with `cache_all_platforms` and `specific_platform` configured (cherry picked from commit e0f6ce6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…atform_issue Fix issue with `cache_all_platforms` and `specific_platform` configured (cherry picked from commit e0f6ce6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…atform_issue Fix issue with `cache_all_platforms` and `specific_platform` configured (cherry picked from commit e0f6ce6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In this case, when running
bundle install, bundler would be unable to find some gems when updating the cache.The reason is that the set of specs is initially materialized for the current platform for the standard
bundle installbehavior. But then when bundler tries to update the cache, the sources have that set of specs cached, and bundler is unable to find specs that are not for the current platform.What is your fix for the problem, implemented in this PR?
The solution is to invalidate sources cache before materializing for all platforms, so that remote platform specific versions are considered.
Fixes #3328.
Make sure he following tasks are checked