Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specific_platform and cache_all with bundle cache --all-platforms #4022

Merged
merged 7 commits into from Oct 22, 2020
Merged

Fix specific_platform and cache_all with bundle cache --all-platforms #4022

merged 7 commits into from Oct 22, 2020

Commits on Oct 20, 2020

  1. Split global test setup into two different cases 

    Since this logic runs before every test and it's quite heavy, an easy
improvement was to split these two different cases. This test file runs
now on my machine in 18 seconds vs the previous 24 seconds.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    659e570 View commit details
    Browse the repository at this point in the history

  2. bin/rake spec:deps uses HEAD bundler 

    Commit to source control changes it creates.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    9800602 View commit details
    Browse the repository at this point in the history

  3. Add windows platform to lockfiles 

    So that bundling under Windows doesn't create source control changes,
and so that the resolution is deterministic every bundler developer
running on Windows.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    82adace View commit details
    Browse the repository at this point in the history

  4. Add x86_64-linux to the lockfile as well 

    So that working on my environment in bundler 3 mode doesn't generate
source control changes either.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    8b9d009 View commit details
    Browse the repository at this point in the history

  5. Remove duplicated specs

    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    3547470 View commit details
    Browse the repository at this point in the history

  6. Reuse lockfile_platforms helper to remove another duplicated spec

    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    004560d View commit details
    Browse the repository at this point in the history

  7. Make sure git gems are properly cached 

    When using the `cache_all` setting, git gems are also cached. Also, when
using `--all-platforms`, gems for all platforms should be cached. Since
`git` gems supporting multiple platforms usually provide a single
gemspec, we need to special case that, otherwise the versions of the git
gems for platforms different than the running one wouldn't be found
because the gemspec would've been evaluated only for the current
platform.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 20, 2020
    Copy the full SHA
    127e56e View commit details
    Browse the repository at this point in the history