Fix specific_platform and cache_all with bundle cache --all-platforms
#4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this logic runs before every test and it's quite heavy, an easy improvement was to split these two different cases. This test file runs now on my machine in 18 seconds vs the previous 24 seconds.
Commit to source control changes it creates.
So that bundling under Windows doesn't create source control changes, and so that the resolution is deterministic every bundler developer running on Windows.
So that working on my environment in bundler 3 mode doesn't generate source control changes either.
When using the `cache_all` setting, git gems are also cached. Also, when using `--all-platforms`, gems for all platforms should be cached. Since `git` gems supporting multiple platforms usually provide a single gemspec, we need to special case that, otherwise the versions of the git gems for platforms different than the running one wouldn't be found because the gemspec would've been evaluated only for the current platform.
deivid-rodriguez
force-pushed
the
fix_package_all_specific_platform_issue
branch
from
0b4defd
to
127e56e
Compare
This was referenced Oct 20, 2020
Closed
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…orm_issue Fix `specific_platform` and `cache_all` with `bundle cache --all-platforms` (cherry picked from commit 1f70226)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…orm_issue Fix `specific_platform` and `cache_all` with `bundle cache --all-platforms` (cherry picked from commit 1f70226)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…orm_issue Fix `specific_platform` and `cache_all` with `bundle cache --all-platforms` (cherry picked from commit 1f70226)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…orm_issue Fix `specific_platform` and `cache_all` with `bundle cache --all-platforms` (cherry picked from commit 1f70226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If using the
specific_platformandcache_allsetting, it is expected thatgitgems will be cached.However, enabling
specific_platformcauses bundler to look only for platform specific versions of thegemspecin thegitsource, which is something that hardly ever happens.What is your fix for the problem, implemented in this PR?
Specially case this situation so that the git gem is properly cached in this case.
Fixes #3361.
Make sure he following tasks are checked