Lazily load time, cgi, and zlib
#4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only needed for `Package` instances.
It's only needed for `UriFormatter` instances.
hsbt
approved these changes
Oct 12, 2020
deivid-rodriguez
added
rubygems: enhancement
and removed
rubygems: minor enhancement
labels
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Lazily load `time`, `cgi`, and `zlib` (cherry picked from commit 0af1449)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Lazily load `time`, `cgi`, and `zlib` (cherry picked from commit 0af1449)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a spec for #3991, I noticed that these default gems are loaded eagerly every time
rubygems/dependency_installeris required.The spec I was writing requires me to use a fresh dummy location for default gems, but since these gems are loaded, I'm also required to create dummy versions of these gems in there too.
I figured that a better solution than making the test more complicated is to lazily load these default gem dependencies only when they are used.
Make sure he following tasks are checked