Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily load erb #4011

Merged
merged 1 commit into from Oct 12, 2020
Merged

Lazily load erb #4011

merged 1 commit into from Oct 12, 2020

Conversation

deivid-rodriguez
Copy link
Member

Similarly to #4010, I noticed that the erb default gem is activated everytime gemfile(true, &block) is used.

This technically prevents using the erb gem in this kind of situation, and also difficults writing a spec for #3991.

So, let's lazily load erb when it's needed.

Make sure he following tasks are checked

@hsbt hsbt added this to the RubyGems 3.2.0/Bundler 2.2.0 milestone Oct 12, 2020
@deivid-rodriguez deivid-rodriguez merged commit 5d32586 into master Oct 12, 2020
@deivid-rodriguez deivid-rodriguez deleted the lazily_load_erb branch October 12, 2020 18:15
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Lazily load `erb`

(cherry picked from commit 5d32586)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Lazily load `erb`

(cherry picked from commit 5d32586)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Lazily load `erb`

(cherry picked from commit 5d32586)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Lazily load `erb`

(cherry picked from commit 5d32586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants