Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some cases of running bundler on a path including brackets #3854

Merged
merged 4 commits into from Oct 1, 2020
Merged

Fix some cases of running bundler on a path including brackets #3854

merged 4 commits into from Oct 1, 2020

Commits on Sep 29, 2020

  1. Lock warbler test to current bundler

    @deivid-rodriguez
    deivid-rodriguez committed Sep 29, 2020
    Copy the full SHA
    1e9c8ac View commit details
    Browse the repository at this point in the history

  2. Use 9.2.11.0 in warbler's realworld test case 

    The test passes on 9.2.9.0, breaks on 9.2.10, and passes again on
9.2.11.1.

Crash is like the following:

```
LoadError: no such file to load -- bundler/shared_helpers
  require at org/jruby/RubyKernel.java:974
  require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
   <main> at uri:classloader:/META-INF/init.rb:21
  require at org/jruby/RubyKernel.java:974
  require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
   <main> at <script>:2
ERROR: org.jruby.embed.EvalFailedException: (LoadError) no such file to load -- bundler/shared_helpers
```

It happens against the current default branch, and I don't know why it
happens.

Whatever it was, it seems fixed in jruby-9.2.11.1, so let's forget about
it.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 29, 2020
    Copy the full SHA
    608d02e View commit details
    Browse the repository at this point in the history

  3. Allow running gem tasks inside paths with brackets

    @deivid-rodriguez
    deivid-rodriguez committed Sep 29, 2020
    Copy the full SHA
    c0d38ce View commit details
    Browse the repository at this point in the history

  4. Fix using the gemspec DSL on a path with brackets in its name

    @deivid-rodriguez
    deivid-rodriguez committed Sep 29, 2020
    Copy the full SHA
    7fe7e7b View commit details
    Browse the repository at this point in the history