Fix some cases of running bundler on a path including brackets
#3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
brackets
branch
from
4270b54
to
949568b
Compare
deivid-rodriguez
force-pushed
the
brackets
branch
5 times, most recently
from
a8f37db
to
2115ad2
Compare
deivid-rodriguez
force-pushed
the
brackets
branch
3 times, most recently
from
b640b7d
to
2d93d8c
Compare
The test passes on 9.2.9.0, breaks on 9.2.10, and passes again on 9.2.11.1. Crash is like the following: ``` LoadError: no such file to load -- bundler/shared_helpers require at org/jruby/RubyKernel.java:974 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54 <main> at uri:classloader:/META-INF/init.rb:21 require at org/jruby/RubyKernel.java:974 require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54 <main> at <script>:2 ERROR: org.jruby.embed.EvalFailedException: (LoadError) no such file to load -- bundler/shared_helpers ``` It happens against the current default branch, and I don't know why it happens. Whatever it was, it seems fixed in jruby-9.2.11.1, so let's forget about it.
deivid-rodriguez
force-pushed
the
brackets
branch
from
2d93d8c
to
7fe7e7b
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix some cases of running `bundler` on a path including brackets (cherry picked from commit 9860c26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I used a a monkey patch of
Gem::Util.glob_files_in_dirthat supports brackets. Something like this will be built in once https://bugs.ruby-lang.org/issues/8258 is implemented, although tobase:option ofDir.globalready handles this fine. So once ruby 2.5 is the minimum support ruby, the monkeypatch can be dropped.Fixes #3841.
Tasks:
I will abide by the code of conduct.