Gem::Specification#to_ruby needs OpenSSL #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
requested changes
Sep 30, 2019
|
This is a duplicate of #2929, but the other PR doesn't have passing tests because of an unrelated issue, so I'm fine merging this as it is. I think the place where the |
deivid-rodriguez
approved these changes
Sep 30, 2019
bronzdoc
approved these changes
Sep 30, 2019
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Sep 30, 2019
2937: Gem::Specification#to_ruby needs OpenSSL r=bronzdoc a=nobu # Description: Since b1d825a, lib/rubygems/specification.rb should require openssl. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Build succeeded |
ghost
merged commit
This was referenced Sep 30, 2019
Closed
4 tasks
hsbt
pushed a commit
that referenced
this pull request
Feb 18, 2020
2937: Gem::Specification#to_ruby needs OpenSSL r=bronzdoc a=nobu # Description: Since b1d825a, lib/rubygems/specification.rb should require openssl. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since b1d825a, lib/rubygems/specification.rb should require openssl.
Tasks:
I will abide by the code of conduct.