New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --enable-load-relative
inside binstubs
#2929
Conversation
d31977f
to
948c451
Compare
Ok, so this PR surfaced an unrelated bug in rubygems installer. On MacOS 2.6.3 ruby seems compiled with the #!/bin/sh
# -*- ruby -*-
_=_\
=begin
bindir="${0%/*}"
exec "$bindir/ruby" "-x" "$0" "$@"
=end
#!/usr/bin/env ruby
#
# This file was generated by RubyGems.
#
# The application 'bundler' is installed as part of a gem, and
# this file is here to facilitate running it.
#
require 'rubygems' Rubygems installer does not support this kind of binstub and thinks it's not a bundler binstub. This is a related ruby-core ticket: https://bugs.ruby-lang.org/issues/13997 |
@deivid-rodriguez can this be closed now that #2937 was merged? |
ruby setup.rb
ruby setup.rb
works
I guess the test could still be useful, so I changed the title to reflect that new scope and will work on it. |
16139bf
to
ded6583
Compare
If I understand well, |
This PR started as the title title suggests but then deviated to fixing the issue manifested by a test failure. So I'm going to rename the PR and will try to rebase it to see how it was going. Regarding the |
ruby setup.rb
works--enable-load-relative
inside binstubs
08ef073
to
26e1f6f
Compare
26e1f6f
to
32a5e90
Compare
I verified manually that this fixes #5245 so I will merge it. |
I think the symlink at the directory (or installing full set) could fix the failures, but it may not be a good way in the tests. |
How do they fail? Everything seems green both here and in ruby-core, no? |
https://github.com/nobu/ruby/runs/4826739682?check_suite_focus=true#step:16:132
It's green because there is no load-relative tests. |
Oh I see, you're running the whole RubyGems suite against a Ruby with |
Support `--enable-load-relative` inside binstubs (cherry picked from commit c0cacf0)
Description:
ruby setup.rb
was broken probably since #2782. Requiringopenssl
fixes it.Closes #2928.When ruby has been compiled with the
--enable-load-relative
configuration, ruby core generates binstub files with some bash code on top, makinggem install
not detect them as rubygems binstubs.Closes #5245.
Tasks:
I will abide by the code of conduct.