Add funding links to sidebar #2522
Conversation
gjtorikian
force-pushed
the
funding_uri
branch
from
c003fa9
to
9275dde
Compare
gjtorikian
force-pushed
the
funding_uri
branch
2 times, most recently
from
cc2e5e1
to
fb820c5
Compare
test/unit/rubygem_searchable_test.rb
Outdated
| @@ -15,7 +15,8 @@ class RubygemSearchableTest < ActiveSupport::TestCase | |||
| number: "1.0.1", | |||
| rubygem: @rubygem, | |||
| summary: "some summary", | |||
| description: "some description") | |||
| description: "some description", | |||
| metadata: { "funding_uri" => "http://example.com" }) | |||
There was a problem hiding this comment.
you will need to specify all *_uri keys in this.
sorry, this is a bit confusing, this test should have been updated when we migrated to metadata links.
There was a problem hiding this comment.
I actually can't run tests locally so hopefully this works.
There was a problem hiding this comment.
let us know if something is not working on dev set up, we have a docker compose file for all services deps.
gjtorikian
force-pushed
the
funding_uri
branch
from
fb820c5
to
3a691d3
Compare
gjtorikian
force-pushed
the
funding_uri
branch
from
3a691d3
to
7666826
Compare
| "mailing_list_uri" => "http://example.com", | ||
| "bug_tracker_uri" => "http://example.com", | ||
| "funding_uri" => "http://example.com" | ||
| }, |
There was a problem hiding this comment.
you seem to have dropped the change for which we had to update metadata.
funding_uri: "HTTP://example.com"
There was a problem hiding this comment.
Didn't you just tell me not to do that? #2522 (comment)
This test makes no sense to me, I'm sorry. Are you able to just push to this branch directly? I do not know anything about legacy metadata or broken tests, I just want to show a single link on an HTML page. 😭
There was a problem hiding this comment.
we are testing if metadata uri keys are indexed to ES as expected. I have added some info about the key where the assert may fail.
Also, adds test to ensure funding_uri method exists on Links.
gjtorikian
force-pushed
the
funding_uri
branch
from
42def3e
to
c4ca9d3
Compare
|
Thank you @gjtorikian |
Building off of rubygems/rubygems#3060 and rubygems/rubygems#3390, this adds the
funding_uriinformation to a gem's page on rubygems.org.