Skip to content

Commit

Permalink
Add documentation_uri to searchable test metadata
Browse files Browse the repository at this point in the history
Also, adds test to ensure funding_uri method exists on Links.
  • Loading branch information
sonalkr132 committed Oct 2, 2020
1 parent 7666826 commit 42def3e
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 13 deletions.
31 changes: 31 additions & 0 deletions test/unit/links_test.rb
Expand Up @@ -55,4 +55,35 @@ class LinksTest < ActiveSupport::TestCase

assert links.homepage_uri
end

context "metadata includes non whitelisted uri key" do
setup do
metadata = {
"homepage_uri" => "https://example.com",
"source_code_uri" => "https://example.com",
"wiki_uri" => "https://example.com",
"mailing_list_uri" => "https://example.com",
"bug_tracker_uri" => "https://example.com",
"funding_uri" => "https://example.com",
"documentation_uri" => "https://example.com",
"changelog_uri" => "https://example.com",
"non_whitelisted_uri" => "https://example.com"
}

version = build(:version, metadata: metadata)
rubygem = build(:rubygem, versions: [version])
@links = rubygem.links(version)
end

should "create method for whitelisted keys" do
whitelisted_keys = Links::LINKS.values.reject! { |k| k == "download_uri" }
whitelisted_keys.each do |key|
assert_equal "https://example.com", @links.send(key), "value doesn't match for method: #{key}"
end
end

should "not create method for non whitelisted key" do
refute @links.respond_to?("non_whitelisted_uri")
end
end
end
29 changes: 16 additions & 13 deletions test/unit/rubygem_searchable_test.rb
Expand Up @@ -17,12 +17,13 @@ class RubygemSearchableTest < ActiveSupport::TestCase
summary: "some summary",
description: "some description",
metadata: {
"homepage_uri" => "http://example.com",
"source_code_uri" => "http://example.com",
"wiki_uri" => "http://example.com",
"mailing_list_uri" => "http://example.com",
"bug_tracker_uri" => "http://example.com",
"funding_uri" => "http://example.com"
"homepage_uri" => "http://example.com",
"source_code_uri" => "http://example.com",
"wiki_uri" => "http://example.com",
"mailing_list_uri" => "http://example.com",
"bug_tracker_uri" => "http://example.com",
"funding_uri" => "http://example.com",
"documentation_uri" => "http://example.com"
})
end

Expand All @@ -44,12 +45,13 @@ class RubygemSearchableTest < ActiveSupport::TestCase
info: "some description",
licenses: "MIT",
metadata: {
"homepage_uri" => "http://example.com",
"source_code_uri" => "http://example.com",
"wiki_uri" => "http://example.com",
"mailing_list_uri" => "http://example.com",
"bug_tracker_uri" => "http://example.com",
"funding_uri" => "http://example.com"
"homepage_uri" => "http://example.com",
"source_code_uri" => "http://example.com",
"wiki_uri" => "http://example.com",
"mailing_list_uri" => "http://example.com",
"bug_tracker_uri" => "http://example.com",
"funding_uri" => "http://example.com",
"documentation_uri" => "http://example.com"
},
sha: "b5d4045c3f466fa91fe2cc6abe79232a1a57cdf104f7a26e716e0a1e2789df78",
project_uri: "http://localhost/gems/example_gem",
Expand All @@ -60,6 +62,7 @@ class RubygemSearchableTest < ActiveSupport::TestCase
mailing_list_uri: "http://example.com",
source_code_uri: "http://example.com",
bug_tracker_uri: "http://example.com",
funding_uri: "http://example.com",
yanked: false,
summary: "some summary",
description: "some description",
Expand All @@ -68,7 +71,7 @@ class RubygemSearchableTest < ActiveSupport::TestCase
}

expected_hash.each do |k, v|
assert_equal v, json[k]
assert_equal v, json[k], "value doesn't match for key: #{k}"
end
end
end
Expand Down

0 comments on commit 42def3e

Please sign in to comment.