Add more methods to SocketForwarder.
#708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it could be better to create the branch on your forked repository. By the way, the failures in the windows-latest 3.3 case in CI were fixed. You can rebase the branch on the latest master branch. |
ioquatix
force-pushed
the
expose-more-io-methods
branch
from
42e8240
to
6663ad7
Compare
ioquatix
force-pushed
the
expose-more-io-methods
branch
from
6663ad7
to
cac0d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic code that assumes the
Socketinterface will fail if it tries to usewaitorwait_readableorclose_on_execfamily of methods. Can we add these?