Add support for gets(chomp: true).

ruby · Jan 13, 2024 · 8aa3849 · 8aa3849
1 parent 39eaa9f
commit 8aa3849
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/openssl/buffering.rb b/lib/openssl/buffering.rb
@@ -229,7 +229,7 @@ def read_nonblock(maxlen, buf=nil, exception: true)
   #
   # Unlike IO#gets the separator must be provided if a limit is provided.
 
-  def gets(eol=$/, limit=nil)
+  def gets(eol=$/, limit=nil, chomp: false)
     idx = @rbuffer.index(eol)
     until @eof
       break if idx
@@ -244,7 +244,11 @@ def gets(eol=$/, limit=nil)
     if size && limit && limit >= 0
       size = [size, limit].min
     end
-    consume_rbuff(size)
+    line = consume_rbuff(size)
+    if chomp && line
+      line.chomp!(eol)
+    end
+    line
   end
 
   ##

diff --git a/test/openssl/test_pair.rb b/test/openssl/test_pair.rb
@@ -115,6 +115,17 @@ def test_gets
     }
   end
 
+  def test_gets_chomp
+    ssl_pair {|s1, s2|
+      s1 << "line1\r\nline2\r\nline3\r\n"
+      s1.close
+
+      assert_equal("line1", s2.gets("\r\n", chomp: true))
+      assert_equal("line2\r\n", s2.gets("\r\n", chomp: false))
+      assert_equal("line3", s2.gets(chomp: true))
+    }
+  end
+
   def test_gets_eof_limit
     ssl_pair {|s1, s2|
       s1.write("hello")