Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom printer support #319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Custom printer support #319

wants to merge 2 commits into from

Commits on Jan 26, 2023

  1. Add support for giving a custom printer from the CLI 

    This allows the use of gems like https://github.com/chanzuckerberg/ruby-prof-speedscope :

- change `--printer` can take a class name instead of just a name of a builtin
- add `--printer-require` for a require for a printer
- add `load_printer` which is called during parse_args... after they are
  parsed, but before checking the output directory

I initially tried not adding --printer-require, and re-using
--require-noprof, but that didn't load the printer in time.
    @technicalpickles
    technicalpickles committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    43127c3 View commit details
    Browse the repository at this point in the history

  2. Add more error handling, and display usage

    @technicalpickles
    technicalpickles committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    4dedbf4 View commit details
    Browse the repository at this point in the history