Custom printer support #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of gems like https://github.com/chanzuckerberg/ruby-prof-speedscope : - change `--printer` can take a class name instead of just a name of a builtin - add `--printer-require` for a require for a printer - add `load_printer` which is called during parse_args... after they are parsed, but before checking the output directory I initially tried not adding --printer-require, and re-using --require-noprof, but that didn't load the printer in time.
|
Did you still want to merge this? I saw the original github issue was closed so I figured this was no longer valid, but looking at it maybe it is? I'm good with this, but as you suspected, without the facets dependency. If you update the PR without it, I am happy to merge it. Sorry for not looking at this sooner. |
|
I think it's still useful. The original PR was accidentally opened against my fork, not this 🙃 I'll update and ping when ready. |
|
Great thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to use a custom printer from the command-line. Specifically, ruby-prof-speedscope.
I've extended the CLI to:
I ended up adding
facetsto get theString#modularizemethod. If this approach is generally acceptable, but an extra dependency isn't, I'm happy to extract copy it or ActiveSupport's implementation, similar to what is done forconstantize