Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpolate now works for an array #282

Closed
wants to merge 6 commits into from
Closed

Interpolate now works for an array #282

wants to merge 6 commits into from

Commits on Dec 4, 2016

  1. Interpolate now works for array

    Bartuz authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    a14a34f View commit details
    Browse the repository at this point in the history

  2. Update interpolation.rb 

    removes unnecessary line
    Filip Bartuzi authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    bc44aba View commit details
    Browse the repository at this point in the history

  3. Refactor interpolation method 

    Suggested by @clemens
    @Bartuz
    Bartuz authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    1debaf6 View commit details
    Browse the repository at this point in the history

  4. Add comments exaplining new array behaviour for #interpolate

    @Bartuz
    Bartuz authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    ebd84b7 View commit details
    Browse the repository at this point in the history

  5. Fix specs for array interpolation 

    It covers full use case now.
Thankfully to ruby-i18n#282 (comment)
    @Bartuz
    Bartuz authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    e0b5f21 View commit details
    Browse the repository at this point in the history

  6. Remove redundant test for lookup 

    This reverts PART of commit ee27f3d.
thanks @clemens
https://github.com/svenfuchs/i18n/pull/282/files#r37780129
    @Bartuz
    Bartuz authored and Filip Bartuzi committed Dec 4, 2016
    Copy the full SHA
    320404c View commit details
    Browse the repository at this point in the history