Interpolate now works for an array #282

Bartuz · 2014-08-25T22:37:05Z

Fixes #281

Credits for @ahmadsherif, thank you Ahmad!

tigrish · 2014-08-29T10:58:51Z

Looks good! Happy to merge when I get back from holidays unless anybody else wants to look into this first?

On 26 Aug 2014, at 00:37, Filip Bartuzi notifications@github.com wrote:

Fixes #281

Credits for @ahmadsherif, thank you Ahmad!

You can merge this Pull Request by running

git pull https://github.com/Bartuz/i18n master
Or view, comment on, or merge it at:

#282

Commit Summary

Interpolate now works for array
File Changes

M lib/i18n/backend/base.rb (2)
M lib/i18n/tests/interpolation.rb (6)
M lib/i18n/tests/lookup.rb (6)
Patch Links:

https://github.com/svenfuchs/i18n/pull/282.patch
https://github.com/svenfuchs/i18n/pull/282.diff
—
Reply to this email directly or view it on GitHub.

Bartuz · 2014-09-03T12:51:51Z

Any updates?

seabornlee · 2015-01-24T14:05:56Z

What happened? Still not support?

Bartuz · 2015-01-24T14:13:33Z

Code works but it's not merged yet. If you want to use it is I would recommend you reading this: http://stackoverflow.com/a/25484080

Wysłane z iPhone'a

Dnia 24 sty 2015 o godz. 15:05 Seaborn Lee notifications@github.com napisał(a):

What happened? Still not support?

—
Reply to this email directly or view it on GitHub.

seabornlee · 2015-01-25T00:59:39Z

@Bartuz Thanks!

Bartuz · 2015-03-09T12:58:35Z

Still not any news?

PikachuEXE · 2015-03-12T07:29:19Z

@tigrish Please take a look when you have time :)

zimkies · 2015-08-18T22:52:03Z

@tigrish any word on this? Seems like a really useful feature without any downsides

Bartuz · 2015-08-19T05:13:14Z

It's been almost a year since I opened pull request 😞

carlosantoniodasilva · 2015-08-19T10:33:29Z

Ya, sorry about that, I'm planning to get back to i18n in the upcoming days/weeks, things have been a bit crazy around here :), I'll keep this one on my radar and check back soon. Thanks everyone!

jhaagmans · 2015-08-24T13:35:29Z

Do mind that @tigrish has once said he wished "that i18n didn't support it as a data type in the first place". I don't fully agree, but this might have something to do with not merging the initial PR:
#242

clemens · 2015-08-24T17:52:34Z

lib/i18n/backend/base.rb

@@ -150,6 +150,8 @@ def pluralize(locale, entry, count)
        def interpolate(locale, string, values = {})
          if string.is_a?(::String) && !values.empty?
            I18n.interpolate(string, values)
+          elsif string.is_a?(::Array) && !values.empty?
+            string.map { |el| interpolate(locale, el, values) }
          else
            string
          end


IMO this whole method should be rewritten to make it clearer and cut down repetition:

def interpolate(locale, subject, values = {}) return subject if values.empty? case subject when ::String then I18n.interpolate(subject, values) when ::Array then subject.map { |element| interpolate(locale, element, values) } else subject end end

It covers full use case now. Thankfully to ruby-i18n#282 (comment)

Bartuz · 2015-09-12T21:26:12Z

Passed on my machine... - ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-darwin14.0]

#324

PikachuEXE · 2015-09-12T23:31:54Z

Travis matrix buggy :S

Bartuz · 2015-09-12T23:33:30Z

But something is wrong anyway: #324

cavi21 · 2016-05-30T18:02:04Z

There is no news about this right?
If there is no plans to include this it would be great to know

Thanks to all

radar · 2016-11-15T21:33:19Z

Looks fine to me. Just going to wait on the build and then once that's showing green I'll merge this.

Bartuz · 2016-11-19T09:58:44Z

Installing json 1.8.2 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

on Rails 4.2.x travis build.

is it possible my commits caused it? I doubt it...

radar · 2016-11-20T20:52:48Z

Try a "bundle update json" and then committing Gemfile.lock and see if that fixes it

On 19 Nov. 2016, at 20:58, Filip Bartuzi notifications@github.com wrote:

Installing json 1.8.2 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
on Rails 4.2.x travis build.

is it possible my commits caused it? I doubt it...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

removes unnecessary line

@clemens

Suggested by @clemens

It covers full use case now. Thankfully to ruby-i18n#282 (comment)

@clemens

This reverts PART of commit ee27f3d. thanks @clemens https://github.com/svenfuchs/i18n/pull/282/files#r37780129

shaneog · 2016-12-04T18:51:52Z

Anxiously awaiting this 👍

florrain · 2017-06-19T16:02:40Z

+1

AM-R · 2017-11-18T01:25:38Z

Damned, why this fix is still not applied?

radar · 2017-11-18T02:35:08Z

ryanbigg.com/now could be a reason, perhaps?

…

On 18 Nov 2017, at 12:25, am ***@***.***> wrote: Damned, why this fix is still not applied? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

radar · 2017-11-18T04:45:07Z

@AM-R: perhaps you could test the fix in #395 for me and tell me if works? That would certainly expedite the process of getting this fixed.

radar · 2017-11-19T21:58:23Z

#395 has been merged. Please try the latest i18n master.

Bartuz changed the title ~~Interpolate now works for array~~ Interpolate now works for an array Aug 25, 2014

clemens reviewed Aug 24, 2015
View reviewed changes

Bartuz added a commit to Bartuz/i18n that referenced this pull request Sep 12, 2015

Fix specs for array interpolation

16d904b

It covers full use case now. Thankfully to ruby-i18n#282 (comment)

Bartuz closed this Nov 2, 2016

Bartuz reopened this Nov 2, 2016

radar added this to the 0.8.0 milestone Nov 15, 2016

Bartuz and others added 4 commits December 4, 2016 17:42

Interpolate now works for array

a14a34f

Update interpolation.rb

bc44aba

removes unnecessary line

Refactor interpolation method

1debaf6

Suggested by @clemens

Add comments exaplining new array behaviour for #interpolate

ebd84b7

Bartuz added 2 commits December 4, 2016 17:42

Fix specs for array interpolation

e0b5f21

It covers full use case now. Thankfully to ruby-i18n#282 (comment)

Remove redundant test for lookup

320404c

This reverts PART of commit ee27f3d. thanks @clemens https://github.com/svenfuchs/i18n/pull/282/files#r37780129

Bartuz force-pushed the master branch from b5e70f8 to 320404c Compare December 4, 2016 16:42

stereobooster mentioned this pull request Nov 9, 2017

Interpolate for arrays #395

Merged

radar closed this Nov 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interpolate now works for an array #282

Interpolate now works for an array #282

Bartuz commented Aug 25, 2014

tigrish commented Aug 29, 2014

Bartuz commented Sep 3, 2014

seabornlee commented Jan 24, 2015

Bartuz commented Jan 24, 2015

seabornlee commented Jan 25, 2015

Bartuz commented Mar 9, 2015

PikachuEXE commented Mar 12, 2015

zimkies commented Aug 18, 2015

Bartuz commented Aug 19, 2015

carlosantoniodasilva commented Aug 19, 2015

jhaagmans commented Aug 24, 2015

clemens Aug 24, 2015

Bartuz commented Sep 12, 2015

PikachuEXE commented Sep 12, 2015

Bartuz commented Sep 12, 2015

cavi21 commented May 30, 2016

radar commented Nov 15, 2016

Bartuz commented Nov 19, 2016

radar commented Nov 20, 2016

shaneog commented Dec 4, 2016

florrain commented Jun 19, 2017

AM-R commented Nov 18, 2017

radar commented Nov 18, 2017 via email

radar commented Nov 18, 2017

radar commented Nov 19, 2017 •

edited

Interpolate now works for an array #282

Interpolate now works for an array #282

Conversation

Bartuz commented Aug 25, 2014

tigrish commented Aug 29, 2014

Bartuz commented Sep 3, 2014

seabornlee commented Jan 24, 2015

Bartuz commented Jan 24, 2015

seabornlee commented Jan 25, 2015

Bartuz commented Mar 9, 2015

PikachuEXE commented Mar 12, 2015

zimkies commented Aug 18, 2015

Bartuz commented Aug 19, 2015

carlosantoniodasilva commented Aug 19, 2015

jhaagmans commented Aug 24, 2015

clemens Aug 24, 2015

Choose a reason for hiding this comment

Bartuz commented Sep 12, 2015

PikachuEXE commented Sep 12, 2015

Bartuz commented Sep 12, 2015

cavi21 commented May 30, 2016

radar commented Nov 15, 2016

Bartuz commented Nov 19, 2016

radar commented Nov 20, 2016

shaneog commented Dec 4, 2016

florrain commented Jun 19, 2017

AM-R commented Nov 18, 2017

radar commented Nov 18, 2017 via email

radar commented Nov 18, 2017

radar commented Nov 19, 2017 • edited

radar commented Nov 19, 2017 •

edited