Don't store translations for locales not set as available with I18n#available_locales= #261
Conversation
|
I am not sure what bug this is fixing. Do you have a simple test case that I can use to reproduce it? I've looked at the test included in this PR and it doesn't make sense as a way to reproduce this bug for me. |
|
Frameworks/Apps using this gem usually include in the load path for translations all the translation files that they find: Some projects use the default translations provided by other gems, and they also add all locale files to the load path. For instance: With all those files in the "l18n.load_path", on initialization, the simple backend will parse and load in memory ALL translations found in all the files: This pull request tries to only load translations for the specified available locales, even if there are translations in the load path for a lot more languages. They are being kept in memory and never used. |
| @@ -29,6 +29,11 @@ def initialized? | |||
| # translations will be overwritten by new ones only at the deepest | |||
| # level of the hash. | |||
| def store_translations(locale, data, options = {}) | |||
| if I18n.available_locales_initialized? && | |||
| I18n.available_locales.include?(locale.to_sym) == false && | |||
There was a problem hiding this comment.
You could probably reduce this to just !I18n.available_locales.map(&:to_s).include?(locale.to_s)
|
Ok, that makes sense to me. Please update this PR against the current master branch and fix the code that I commented on. |
|
Superseded by #391. |
If available locales are set explicitly, that means we don't want to work with other locales. This commit puts a check on Simple#store_translation to check if @@available_locales has been set explicitly, and in that case, does not store the data.
Right now, this translations are kept in memory and cached, but never used.
If the value of 'available_locales' is not set explicitly, it works as before, storing translations in any locale.