fix for reseting available locales Cache on load_path changes #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This make sense... not sure about the implementation tho, if we should extract that |
dmitry
suggested changes
Nov 17, 2016
| @@ -110,12 +110,14 @@ def missing_interpolation_argument_handler=(exception_handler) | |||
| # register translation files like this: | |||
| # I18n.load_path << 'path/to/locale/en.yml' | |||
| def load_path | |||
| reset_available_locales_set | |||
| @@load_path ||= [] | |||
There was a problem hiding this comment.
load_path= must be defined as a method, and in case of resetting it should trigger reset of available locales.
|
#261 and this PR should work together. |
|
@radar seems like either this could be merged (since it's all green) or closed (since the other linked PR was also closed)? Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using simple backend and changing the load_path the locales Cache wasn't updating to show updated available_locales. By "reseting" cache it forces to create a new one whenever load_path is changed.