Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AtExit code #841

Merged
merged 11 commits into from Feb 7, 2020
Merged

Remove AtExit code #841

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a16092
Remove AtExit code
fzakaria Jan 27, 2020
8956b90
auto_termination related cleanups
pitr-ch Feb 2, 2020
2dd2101
Update CHANGELOG.md
fzakaria Feb 2, 2020
7557b70
Update lib/concurrent-ruby/concurrent/configuration.rb
fzakaria Feb 2, 2020
9800707
Update lib/concurrent-ruby/concurrent/configuration.rb
fzakaria Feb 2, 2020
af3a1f0
Add daemon thread factory for SingleThreadExecutor
fzakaria Feb 3, 2020
19b1a7e
remove forgotten fulfilled todo
pitr-ch Feb 5, 2020
9426e88
DaemonThreadFactory is private
pitr-ch Feb 5, 2020
9cfbd78
Do not set auto_terminate twice
pitr-ch Feb 5, 2020
f2de94a
Allow the child process to be already gone
pitr-ch Feb 5, 2020
2c13ac6
Moved auto_terminate daemon test to executor_service_shared.rb
fzakaria Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/concurrent/executor/cached_thread_pool_spec.rb
View file
Open in desktop
Expand Up @@ -212,6 +212,8 @@ module Concurrent
pid = spawn RbConfig.ruby, test_file
Process.waitpid pid
expect($?.success?).to eq true
rescue Errno::ECHILD
# child already gone
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I was also fixing this :)

            rescue Errno::ECHILD
              # the child could quit out fast enough before we try to wait for it!

I think we could TODO move this test to executor_service_shared & have pool_quits start every type of executor service: cached & single executor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that sounds like a good idea! Would you be willing to do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rescue Timeout::Error => e
Process.kill :KILL, pid
raise e
Expand Down