Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AtExit code #841

Merged
merged 11 commits into from Feb 7, 2020
Merged

Commits on Jan 27, 2020

  1. Remove AtExit code

    Following ruby-concurrency#840 which allowed all threads created by concurrent-ruby
    to be marked as daemon -- specifically in JRuby; the "AtExit" handling
    is no longer needed.
    
    Delete all references to "AtExit" and replace it with clearer
    documentation that the users can select whether the threads started
    shall be marked as daemon threads.
    
    > When a Java Virtual Machine starts up, there is usually a single non-daemon thread (which typically calls the method named main of some designated class).
    > The Java Virtual Machine continues to execute threads until either of the following occurs:
    >
    > 1. The exit method of class Runtime has been called and the security manager has permitted the exit operation to take place.
    > 2. All threads that are not daemon threads have died, either by returning from the call to the run method or by throwing an exception that propagates beyond the run method.
    fzakaria committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4a16092 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. auto_termination related cleanups

    - disable_at_exit_handlers! has to be kept as noop not to break current usages
    - cleanup auto_terminate handling
    - remove ns_auto_terminate attribute
    - deprecate auto_terminate=
    pitr-ch committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    8956b90 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    Add @LikeLakers2 suggestion.
    
    Co-Authored-By: MichiRecRoom <1008889+LikeLakers2@users.noreply.github.com>
    2 people authored and pitr-ch committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    2dd2101 View commit details
    Browse the repository at this point in the history
  3. Update lib/concurrent-ruby/concurrent/configuration.rb

    Fix grammatical error in configuration.rb
    fzakaria authored and pitr-ch committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    7557b70 View commit details
    Browse the repository at this point in the history
  4. Update lib/concurrent-ruby/concurrent/configuration.rb

    Fix grammatical error in configuration.rb
    fzakaria authored and pitr-ch committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    9800707 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    af3a1f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Configuration menu
    Copy the full SHA
    19b1a7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9426e88 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cfbd78 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f2de94a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    2c13ac6 View commit details
    Browse the repository at this point in the history