Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9973] Fix a false positive for Layout/RescueEnsureAlignment #9974

Conversation

koic
Copy link
Member

@koic koic commented Aug 3, 2021

Fixes #9973.

This PR fixes a false positive for Layout/RescueEnsureAlignment when aligned rescue keyword and leading dot.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ment`

Fixes rubocop#9973.

This PR fixes a false positive for `Layout/RescueEnsureAlignment`
when aligned `rescue` keyword and leading dot.
@koic koic force-pushed the fix_false_positive_for_layout_rescue_ensure_alignment branch from d8f727a to 15886e3 Compare August 4, 2021 01:55
@bbatsov bbatsov merged commit 2fd1221 into rubocop:master Aug 12, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 12, 2021

Looks good!

@koic koic deleted the fix_false_positive_for_layout_rescue_ensure_alignment branch August 12, 2021 07:29
@casperisfine
Copy link

I think this change doesn't handle some case properly, after upgrading to 1.19

def some_method
  super do
    nil
  ensure
    nil
  end
end
An error occurred while Layout/RescueEnsureAlignment cop was inspecting xxx.rb:6:4.
undefined method `selector' for #<Parser::Source::Map::Keyword:0x00007ff5c1ba1cb0 @keyword=#<Parser::Source::Range xxx.rb 62...67>, @end=nil, @begin=nil, @expression=#<Parser::Source::Range xxx.rb 62...67>, @node=s(:zsuper)>
  ~/gems/rubocop-1.19.0/lib/rubocop/cop/layout/rescue_ensure_alignment.rb:140:in `aligned_with_line_break_method?'
  ~/gems/rubocop-1.19.0/lib/rubocop/cop/layout/rescue_ensure_alignment.rb:121:in `alignment_node'
  ~/gems/rubocop-1.19.0/lib/rubocop/cop/layout/rescue_ensure_alignment.rb:58:in `check'
  ~/gems/rubocop-1.19.0/lib/rubocop/cop/layout/rescue_ensure_alignment.rb:41:in `on_ensure'

@koic
Copy link
Member Author

koic commented Aug 16, 2021

@casperisfine Thanks for your feedback. I will take it.

koic added a commit to koic/rubocop that referenced this pull request Aug 16, 2021
Follow up to rubocop#9974 (comment).

This PR fixes an error for `Layout/RescueEnsureAlignment`
when using zsuper with block.
bbatsov pushed a commit that referenced this pull request Aug 17, 2021
Follow up to #9974 (comment).

This PR fixes an error for `Layout/RescueEnsureAlignment`
when using zsuper with block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questionable detection and autocorrect by Layout/RescueEnsureAlignment
3 participants