Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Layout/RescueEnsureAlignment #10017

Merged
merged 1 commit into from Aug 17, 2021

Conversation

koic
Copy link
Member

@koic koic commented Aug 16, 2021

Follow up to #9974 (comment).

This PR fixes an error for Layout/RescueEnsureAlignment when using zsuper with block.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up to rubocop#9974 (comment).

This PR fixes an error for `Layout/RescueEnsureAlignment`
when using zsuper with block.
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 17, 2021

Thanks!

@bbatsov bbatsov merged commit 016f38e into rubocop:master Aug 17, 2021
@koic koic deleted the fix_error_for_rescue_ensure_alignment branch August 17, 2021 06:11
@stasmakutin-st
Copy link

stasmakutin-st commented Jan 4, 2024

Getting this offence for following code with v1.55.1 of rubocop:

    def self.parse(*urls)
      urls&.map do
        Addressable::URI.parse(_1) if _1.present?
      rescue Addressable::URI::InvalidURIError
        nil
      end&.compact
    end

is this a missing case?

@koic
Copy link
Member Author

koic commented Jan 4, 2024

@stasmakutin-st This issue has been resolved in the latest RuboCop. Please upgrade to RuboCop 1.59.0.

@stasmakutin-st
Copy link

@koic thank you! found the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants