[Fix #9953] Fix a false auto-correction behavior for Layout/EndAlignment

changelog/fix_a_false_autocorrection_for_layout_end_alignment.md

@@ -0,0 +1 @@
+* [#9953](https://github.com/rubocop/rubocop/issues/9953): Fix an infinite loop error and a false auto-correction behavior for `Layout/EndAlignment` when using a conditional statement in a method argument. ([@koic][])

lib/rubocop/cop/layout/end_alignment.rb

@@ -165,7 +165,8 @@ def alignment_node(node)
         end
 
         def alignment_node_for_variable_style(node)
-          return node.parent if node.case_type? && node.argument?
+          return node.parent if node.case_type? && node.argument? &&
+                                node.loc.line == node.parent.loc.line
 
           assignment = assignment_or_operator_method(node)
 

spec/rubocop/cop/layout/end_alignment_spec.rb

@@ -339,6 +339,31 @@ module Test
         end
       RUBY
     end
+
+    it 'register an offense when using a conditional statement in a method argument and `end` is not aligned' do
+      expect_offense(<<~RUBY)
+        format(
+          case condition
+          when foo
+            bar
+          else
+            baz
+        end, qux
+        ^^^ `end` at 7, 0 is not aligned with `case` at 2, 2.
+        )
+      RUBY
+
+      expect_correction(<<~RUBY)
+        format(
+          case condition
+          when foo
+            bar
+          else
+            baz
+          end, qux
+        )
+      RUBY
+    end
   end
 
   context 'correct + opposite' do