Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9953] Fix a false auto-correction behavior for Layout/EndAlignment #9960

Conversation

koic
Copy link
Member

@koic koic commented Jul 30, 2021

Fixes #9953.

Fix an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using a conditional statement in a method argument.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ndAlignment`

Fixes rubocop#9953.

Fix an infinite loop error and a false auto-correction behavior for `Layout/EndAlignment`
when using a conditional statement in a method argument.
@koic koic changed the title [Fix #9953] Fix a false auto-correction behavior for `Layout/EndAlign… [Fix #9953] Fix a false auto-correction behavior for Layout/EndAlignment Jul 30, 2021
@bbatsov bbatsov merged commit c257ec5 into rubocop:master Aug 3, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 3, 2021

Thanks!

@koic koic deleted the fix_a_false_autocorrection_for_layout_end_alignment branch August 3, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop on EndAlignment+FirstMethodArgumentLineBreak+FormatString
2 participants