Allow the term "Mastercard" #9893
Conversation
The new cop marks the term "Mastercard" as offensive. Although they should rename the company to Maincard, that's not going to happen soon. This PR allows the term Mastercard by default.
|
😱 |
|
|
|
Hmm, this seems like a bug in the cop as I don't think that it should target |
|
//cc @tjwp - is looking for the problematic terms as part of another word a feature or bug from your perspective? To me it seems like a bug. |
You got mine :) |
For my part this was intentional behavior and there was a test included to document that matching part of a word is expected: https://github.com/rubocop/rubocop/blob/master/spec/rubocop/cop/naming/inclusive_language_spec.rb#L24-L30 I think it makes sense to add an exclusion for I'd also be onboard with disabling this cop by default and letting users provide the configuration that works for them. |
|
@tjwp Got it. Might be a good idea to add some option like |
… `FlaggedTerms` for `Naming/InclusiveLanguage` Fixes rubocop#9895 and follow up rubocop#9893 (comment). This PR sets `CheckStrings: false` and removes `master` from `FlaggedTerms` for `Naming/InclusiveLanguage` because it has an unexpectedly impact for many users who give feedback.
…edTerms` for `Naming/InclusiveLanguage` Fixes #9895 and follow up #9893 (comment). This PR sets `CheckStrings: false` and removes `master` from `FlaggedTerms` for `Naming/InclusiveLanguage` because it has an unexpectedly impact for many users who give feedback.
|
We've cut a new release with a more permissive configuration for the cop. It shouldn't be noisy for anyone at this point. |
The new cop marks the term "Mastercard" as offensive.
Although they should rename the company to Maincard, that's not going to happen soon.
This PR allows the term Mastercard by default.