New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #9895] Disable Naming/InclusiveLanguage
by default
#9896
[Fix #9895] Disable Naming/InclusiveLanguage
by default
#9896
Conversation
Either this or just disabling the checking of string literals, which I think is the real problem. I'm reasonably certain this won't generate much noise for identifier names and file names. In hindsight - it doesn't make much sense for a cop focused on naming to check string literals, as their contents are text, not names. I should have thought of this a bit earlier. :D |
We might also remove |
As the author of this cop, I want to endorse that I'm in support of disabling by default. I think this is a useful tool to put in user's hands but don't want to force it or a specific configuration on anyone. |
16ad963
to
d983382
Compare
@bbatsov Sure! I agree with your suggestions! I updated this PR to set |
I agree with making the default configuration more permissive if this cop is going to be enabled by default. It'd be good to have an exhaustive example of how to configure the cop in the docs though so that people could, for example, just apply the original configuration if they are so inclined. |
… `FlaggedTerms` for `Naming/InclusiveLanguage` Fixes rubocop#9895 and follow up rubocop#9893 (comment). This PR sets `CheckStrings: false` and removes `master` from `FlaggedTerms` for `Naming/InclusiveLanguage` because it has an unexpectedly impact for many users who give feedback.
d983382
to
1976f27
Compare
Follow up to rubocop/rubocop#9896.
Follow up to rubocop/rubocop#9896.
Follow up to rubocop/rubocop#9896.
Follow up to rubocop/rubocop#9896.
Follow up to rubocop/rubocop#9896.
Fixes #9895 and follow up #9893 (comment).
This PR disables
Naming/InclusiveLanguage
by default because it has an unexpectedly impact for many users who give feedback.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.