[Fix #9803] Update Bundler/GemVersion to check commit references

changelog/fix_gem_version_not_respecting_tags.md

@@ -0,0 +1 @@
+* [#9803](https://github.com/rubocop/rubocop/pull/9803): Fix `Bundler/GemVersion` cop not respecting git tags. ([@tejasbubane,@timlkelly][])

lib/rubocop/cop/bundler/gem_version.rb

@@ -3,8 +3,8 @@
 module RuboCop
   module Cop
     module Bundler
-      # Enforce that Gem version specifications are either required
-      # or forbidden.
+      # Enforce that Gem version specifications or a commit reference (branch,
+      # ref, or tag) are either required or forbidden.
       #
       # @example EnforcedStyle: required (default)
       #  # bad
@@ -19,6 +19,15 @@ module Bundler
       #  # good
       #  gem 'rubocop', '>= 1.5.0', '< 1.10.0'
       #
+      #  # good
+      #  gem 'rubocop', branch: 'feature-branch'
+      #
+      #  # good
+      #  gem 'rubocop', ref: '74b5bfbb2c4b6fd6cdbbc7254bd7084b36e0c85b'
+      #
+      #  # good
+      #  gem 'rubocop', tag: 'v1.17.0'
+      #
       # @example EnforcedStyle: forbidden
       #  # good
       #  gem 'rubocop'
@@ -32,6 +41,15 @@ module Bundler
       #  # bad
       #  gem 'rubocop', '>= 1.5.0', '< 1.10.0'
       #
+      #  # bad
+      #  gem 'rubocop', branch: 'feature-branch'
+      #
+      #  # bad
+      #  gem 'rubocop', ref: '74b5bfbb2c4b6fd6cdbbc7254bd7084b36e0c85b'
+      #
+      #  # bad
+      #  gem 'rubocop', tag: 'v1.17.0'
+      #
       class GemVersion < Base
         include ConfigurableEnforcedStyle
         include GemDeclaration
@@ -45,6 +63,11 @@ class GemVersion < Base
           (send nil? :gem <(str #version_specification?) ...>)
         PATTERN
 
+        # @!method includes_commit_reference?(node)
+        def_node_matcher :includes_commit_reference?, <<~PATTERN
+          (send nil? :gem <(hash <(pair (sym {:branch :ref :tag}) (str _)) ...>) ...>)
+        PATTERN
+
         def on_send(node)
           return unless gem_declaration?(node)
           return if allowed_gem?(node)
@@ -78,8 +101,19 @@ def message(range)
         end
 
         def offense?(node)
-          (required_style? && !includes_version_specification?(node)) ||
-            (forbidden_style? && includes_version_specification?(node))
+          required_offense?(node) || forbidden_offense?(node)
+        end
+
+        def required_offense?(node)
+          return unless required_style?
+
+          !includes_version_specification?(node) && !includes_commit_reference?(node)
+        end
+
+        def forbidden_offense?(node)
+          return unless forbidden_style?
+
+          includes_version_specification?(node) || includes_commit_reference?(node)
         end
 
         def forbidden_style?

spec/rubocop/cop/bundler/gem_version_spec.rb

@@ -24,6 +24,9 @@
         gem 'rubocop', '~> 1'
         gem 'rubocop', '~> 1.12', require: false
         gem 'rubocop', '>= 1.5.0', '< 1.10.0', git: 'https://github.com/rubocop/rubocop'
+        gem 'rubocop', branch: 'feature-branch'
+        gem 'rubocop', ref: 'b3f37bc7f'
+        gem 'rubocop', tag: 'v1'
       RUBY
     end
 
@@ -52,6 +55,12 @@
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Gem version specification is forbidden.
         gem 'rubocop', '>= 1.5.0', '< 1.10.0', git: 'https://github.com/rubocop/rubocop'
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Gem version specification is forbidden.
+        gem 'rubocop', branch: 'feature-branch'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Gem version specification is forbidden.
+        gem 'rubocop', ref: 'b3f37bc7f'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Gem version specification is forbidden.
+        gem 'rubocop', tag: 'v1'
+        ^^^^^^^^^^^^^^^^^^^^^^^^ Gem version specification is forbidden.
       RUBY
     end