Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9803] Update Bundler/GemVersion to check commit references #9885

Merged
merged 3 commits into from Jun 25, 2021

Conversation

timlkelly
Copy link
Contributor

@timlkelly timlkelly commented Jun 21, 2021

#9807 seems to be stale. This pull request completes the work it set out to do and will close #9803 and #9807.

I originally wanted to create a pull request to merge into #9807, however, I was not able to figure that out. Probably due to my inexperience when working on git projects across multiple forks.

This differs slightly from #9807 given the conversation that has happened in that pull request:

  • This proposal does not take the hosted git service into consideration
  • This proposal also checks for branch

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Co-authored-by: Daniel Vandersluis <daniel.vandersluis@gmail.com>
@bbatsov bbatsov merged commit 8ff511c into rubocop:master Jun 25, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 25, 2021

Looks good to me! Thanks for driving it to the finish line!

@timlkelly timlkelly deleted the fix-9803-bundler-gem-version branch June 25, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler/GemVersion not respecting tags
4 participants