Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow braced numeric block calls in Style/MethodCallWithArgsParentheses #9854

Merged
merged 1 commit into from Jun 5, 2021
Merged

Allow braced numeric block calls in Style/MethodCallWithArgsParentheses #9854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...g/fix_allow_braced_numeric_blocks_in_style_Method_call_with_args_parentheses.md
View file
Open in desktop
@@ -0,0 +1 @@
* [#9854](https://github.com/rubocop/rubocop/pull/9854): Allow braced numeric blocks in `omit_parentheses` style of `Style/MethodCallWithArgsParentheses`. ([@gsamokovarov][])
3 changes: 2 additions & 1 deletion lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb
View file
Open in desktop
Expand Up @@ -116,7 +116,8 @@ def call_with_ambiguous_arguments?(node)
end

def call_with_braced_block?(node)
(node.send_type? || node.super_type?) && node.block_node && node.block_node.braces?
(node.send_type? || node.super_type?) &&
((node.parent&.block_type? || node.parent&.numblock_type?) && node.parent&.braces?)
end

def call_as_argument_or_chain?(node)
Expand Down
8 changes: 8 additions & 0 deletions spec/rubocop/cop/style/method_call_with_args_parentheses_spec.rb
View file
Open in desktop
Expand Up @@ -404,6 +404,14 @@ def method_missing(name, ...)
end
end

context 'numbered parameters in 2.7', :ruby27 do
it 'accepts parens for braced numeric block calls' do
expect_no_offenses(<<~RUBY)
numblock.call(:arg) { _1 }
RUBY
end
end

it 'register an offense for parens in method call without args' do
trailing_whitespace = ' '

Expand Down