Allow braced numeric block calls in Style/MethodCallWithArgsParentheses #9854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another fix for the
omit_parentheses
style of theStyle/MethodCallWithArgsParentheses
cop. We're issuing offenses forbraced
numblock
calls:Removing the parens leads to code that doesn't compile so this is not good.
Numeric block have their own AST node type:
vs
Send nodes can be queried for their block if given with
#block_node
,however, the
numblock
s don't get recognized as such. Our check for bracedblock calls used to rely on it:
https://github.com/rubocop/rubocop-ast/blob/master/lib/rubocop/ast/node/mixin/method_dispatch_node.rb#L35-L37
https://github.com/rubocop/rubocop-ast/blob/master/lib/rubocop/ast/node/mixin/method_dispatch_node.rb#L156-L158
I'm changing the implementation to work around this issue and recognize
numblock
braced calls, but we may consider moving the fix torubocop-ast
as well.