[Fix #9827] Add basic auth support to download raw yml config from private repo #9828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AirWick219
force-pushed
the
support_token_auth
branch
from
39b3280
to
6933447
Compare
AirWick219
changed the title
dvandersluis
requested changes
May 29, 2021
AirWick219
force-pushed
the
support_token_auth
branch
from
b7c1342
to
afd2ab6
Compare
dvandersluis
approved these changes
Jun 2, 2021
koic
approved these changes
Jun 2, 2021
nickpith
reviewed
Jun 3, 2021
lib/rubocop/remote_config.rb
Outdated
| @@ -55,6 +55,7 @@ def request(uri = @uri, limit = 10, &block) | |||
| def generate_request(uri) | |||
| request = Net::HTTP::Get.new(uri.request_uri) | |||
|
|
|||
| request['Authorization'] = "token #{uri.user}" if uri.user | |||
There was a problem hiding this comment.
I'm not sure this really should be Github specific. A Personal Access Token (PAT) can be used in Github using basic auth - which is the syntax suggested here where the user field of the URL is the PAT. Should this line be removed and set the user on the request object like this?
request.basic_auth(uri.user, uri.password) if uri.user
I tested some sample code and this works for Github using a PAT and should work for any URL that supports basic auth.
There was a problem hiding this comment.
O cool. That works. Didn't know PAT works with basic auth. Thanks
AirWick219
changed the title
AirWick219
changed the title
nickpith
approved these changes
Jun 3, 2021
|
@dvandersluis and @koic Let me know if you guys are good with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Token auth support so that users can inherit shared config from the internal private repo.
This addresses #9827
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.