Add support for token auth to download raw yml config from private repo

[AirWick219]

Is your feature request related to a problem?

We are requiring auth for all internal Github repos, we will need a way to inherit and cache the raw yaml shared configs with auth so that RuboCop's existing download and cache logic would work the same way with minimal overall impact.

Describe the solution you'd like

Since inherit_from supports ERB pre-precessing, we can set .rubocop.yml

# .rubocop.yml

inherit_from:
  - <%= "https://#{ENV['GITHUB_PERSONAL_ACCESS_TOKEN']}@raw.github.com/AirWick219/../rubocop-main.yml" %>

and the token is in the uri.user

Seems like we can do this here

request['Authorization'] = "token #{uri.user}" if uri.user

Describe alternatives you've considered

The above solution would be the simplest way to tap into existing logic. if not we will have to.

1. hack it with a new rake task to first download the shared config with curl and inherit_from that file
   • we lost the cache supports and dev will need to run a separate rake task just for rubocop
2. hack a binstub to download the shared config with curl and replace the bin/rubocop
   • still hacky but easier for dev to integrate

[fgoyer]

This could be helpful for when Github forces token-based authentication https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/

[AirWick219]

Here is the PR: #9828

[AirWick219]

cc. @koic

[nickpith]

@bbatsov or @koic - Thanks for accepting this. When were you all thinking of releasing the next version with this fix?

[bbatsov]

Probably some time next week.

…

On Thu, 10 Jun 2021 at 00:25, Nick Smith ***@***.***> wrote: @bbatsov <https://github.com/bbatsov> or @koic <https://github.com/koic> - Thanks for accepting this. When were you all thinking of releasing the next version with this fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9827 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZLSUJHRU6VRGBW32S3JLTR7L5RANCNFSM45SQTX5A> .

-- Best Regards, Bozhidar Batsov

[nickpith]

Thanks