[Fix #9792] Fix false positive for Lint/Void cop
#9796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
May 13, 2021
koic
reviewed
May 13, 2021
koic
reviewed
May 13, 2021
koic
reviewed
May 13, 2021
koic
reviewed
May 13, 2021
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 14, 2021
Follow rubocop#9796 (comment). This PR makes `InternalAffairs/ExampleDescription` aware of descriptions starting with `handles` and `works` when using `expect_no_offenses`.
8 tasks
|
@koic Changed as per your comments. |
koic
reviewed
May 16, 2021
bbatsov
reviewed
May 17, 2021
| @@ -104,7 +104,7 @@ def check_var(node) | |||
| end | |||
|
|
|||
| def check_literal(node) | |||
| return if !node.literal? || node.xstr_type? | |||
| return if !node.literal? || node.xstr_type? || node.range_type? | |||
There was a problem hiding this comment.
I wonder why literal? doesn't cover them. I think they weren't immutable or something like this, but my memory on the subject is fuzzy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9792
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.