Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InternalAffairs/ExampleDescription aware of several words #9797

Conversation

koic
Copy link
Member

@koic koic commented May 14, 2021

Follow #9796 (comment).

This PR makes InternalAffairs/ExampleDescription aware of descriptions starting with handles and works when using expect_no_offenses.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow rubocop#9796 (comment).

This PR makes `InternalAffairs/ExampleDescription` aware of descriptions
starting with `handles` and `works` when using `expect_no_offenses`.
@koic koic merged commit f3a1d32 into rubocop:master May 14, 2021
@koic koic deleted the make_internal_affairs_example_description_aware_of_several_words branch May 14, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants