Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9770] Update Lint/EmptyBlock to handle procs the same way as lambdas #9775

Merged
merged 1 commit into from May 7, 2021

Conversation

dvandersluis
Copy link
Member

Lint/EmptyBlock now treats procs the same way as lambdas (governed by the AllowLambdas configuration).

Fixes #9770.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis
Copy link
Member Author

@bbatsov it'd probably be "better" to replace the AllowLambdas configuration with AllowLambdasAndProcs or something, but this would break existing configurations. I was thinking about deprecating AllowLambdas with a warning (like we did in #9098) but it's probably "good enough" to just overload the configuration.

If you want me to change it, let me know.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably "good enough" to just overload the configuration.

I agree with this opinion. It seems better to me to update the AllowEmptyLambdas configuration.

@bbatsov bbatsov merged commit d1bd888 into rubocop:master May 7, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented May 7, 2021

The change is fine in it's current form. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/EmptyBlock should not apply to empty procs
3 participants