Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Style/NilLambda to handle procs as well #9776

Merged
merged 1 commit into from May 7, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented May 5, 2021

Similarly to #9775, updates Style/NilLambda to handle procs as well.

Like I wrote in #9775 (comment), the naming is a bit off here, but I think it's better than the two alternatives -- create a separate Style/NilProc cop (duplication) or rename Style/NilLambda to NilLambdaAndProc or something (breaking change).


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis merged commit f5863b1 into rubocop:master May 7, 2021
@dvandersluis dvandersluis deleted the nil-lambda-procs branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants