Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/NumberConversion #9757

Merged

Commits on May 2, 2021

  1. Fix a false positive for Lint/NumberConversion

    This PR fixes the following false positive and incorrect auto-correct
    for `Lint/NumberConversion` when `:to_f` is one of multiple method arguments.
    
    ```console
    % cat example.rb
    delegate :to_f, to: :description, allow_nil: true
    
    % bundle exec rubocop --only Lint/NumberConversion -A example.rb
    (snip)
    
    Inspecting 1 file
    W
    
    Offenses:
    
    example.rb:1:1: W: [Corrected] Lint/NumberConversion: Replace unsafe
    number conversion with number class parsing, instead of using :to_f, use
    stricter { |i| Float(i) }.
    delegate :to_f, to: :description, allow_nil: true
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    1 file inspected, 1 offense detected, 1 offense corrected
    
    % cat example.rb
    delegate { |i| Float(i) }, to: :description, allow_nil: true
    
    % ruby -c example.rb
    example.rb:1: syntax error, unexpected ',', expecting end-of-input
    delegate { |i| Float(i) }, to: :description, allow_nil:...
    ```
    koic committed May 2, 2021
    Copy the full SHA
    233aeac View commit details
    Browse the repository at this point in the history