Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/NumberConversion #9757

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 2, 2021

This PR fixes the following false positive and incorrect auto-correct for Lint/NumberConversion when :to_f is one of multiple method arguments.

% cat example.rb
delegate :to_f, to: :description, allow_nil: true

% bundle exec rubocop --only Lint/NumberConversion -A example.rb
(snip)

Inspecting 1 file
W

Offenses:

example.rb:1:1: W: [Corrected] Lint/NumberConversion: Replace unsafe
number conversion with number class parsing, instead of using :to_f, use
stricter { |i| Float(i) }.
delegate :to_f, to: :description, allow_nil: true
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
delegate { |i| Float(i) }, to: :description, allow_nil: true

% ruby -c example.rb
example.rb:1: syntax error, unexpected ',', expecting end-of-input
delegate { |i| Float(i) }, to: :description, allow_nil:...

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following false positive and incorrect auto-correct
for `Lint/NumberConversion` when `:to_f` is one of multiple method arguments.

```console
% cat example.rb
delegate :to_f, to: :description, allow_nil: true

% bundle exec rubocop --only Lint/NumberConversion -A example.rb
(snip)

Inspecting 1 file
W

Offenses:

example.rb:1:1: W: [Corrected] Lint/NumberConversion: Replace unsafe
number conversion with number class parsing, instead of using :to_f, use
stricter { |i| Float(i) }.
delegate :to_f, to: :description, allow_nil: true
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
delegate { |i| Float(i) }, to: :description, allow_nil: true

% ruby -c example.rb
example.rb:1: syntax error, unexpected ',', expecting end-of-input
delegate { |i| Float(i) }, to: :description, allow_nil:...
```
@bbatsov bbatsov merged commit baba552 into rubocop:master May 2, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented May 2, 2021

Thanks!

@koic koic deleted the fix_a_false_positive_for_lint_number_conversion branch May 2, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants