Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Style/MethodCallWithArgsParentheses #9715

Commits on Apr 20, 2021

  1. Fix an incorrect auto-correct for Style/MethodCallWithArgsParentheses

    This PR fixes the following incorrect auto-correct for `Style/MethodCallWithArgsParentheses`
    with `Style/RescueModifier`.
    
    ```console
    % cat example.rb
    do_something arg rescue nil
    
    % bundle exec rubocop -a --only
    Style/MethodCallWithArgsParentheses,Style/RescueModifier
    (snip)
    
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:1:1: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
    parentheses for method calls with arguments.
    do_something arg rescue nil
    ^^^^^^^^^^^^^^^^
    example.rb:1:1: C: [Corrected] Style/RescueModifier: Avoid using rescue
    in its modifier form.
    do_something arg rescue nil
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    1 file inspected, 2 offenses detected, 2 offenses corrected
    ```
    
    ## Before
    
    Auto-corrected to invalid syntax.
    
    ```ruby
    % cat example.rb
    begin
      do_something(arg
    rescue
      nil
    end)
    
    % ruby -c example.rb
    example.rb:3: syntax error, unexpected `rescue', expecting ')'
    rescue
    example.rb:5: syntax error, unexpected ')', expecting end-of-input
    ```
    
    ## After
    
    Auto-corrected to valid syntax.
    
    ```ruby
    % cat example.rb
    begin
      do_something(arg)
    rescue
      nil
    end
    ```
    koic committed Apr 20, 2021
    Copy the full SHA
    cc02650 View commit details
    Browse the repository at this point in the history