Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Style/MethodCallWithArgsParentheses #9715

Conversation

koic
Copy link
Member

@koic koic commented Apr 20, 2021

This PR fixes the following incorrect auto-correct for Style/MethodCallWithArgsParentheses with Style/RescueModifier.

% cat example.rb
do_something arg rescue nil

% bundle exec rubocop -a --only
Style/MethodCallWithArgsParentheses,Style/RescueModifier
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:1: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
parentheses for method calls with arguments.
do_something arg rescue nil
^^^^^^^^^^^^^^^^
example.rb:1:1: C: [Corrected] Style/RescueModifier: Avoid using rescue
in its modifier form.
do_something arg rescue nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 2 offenses detected, 2 offenses corrected

Before

Auto-corrected to invalid syntax.

% cat example.rb
begin
  do_something(arg
rescue
  nil
end)

% ruby -c example.rb
example.rb:3: syntax error, unexpected `rescue', expecting ')'
rescue
example.rb:5: syntax error, unexpected ')', expecting end-of-input

After

Auto-corrected to valid syntax.

% cat example.rb
begin
  do_something(arg)
rescue
  nil
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following incorrect auto-correct for `Style/MethodCallWithArgsParentheses`
with `Style/RescueModifier`.

```console
% cat example.rb
do_something arg rescue nil

% bundle exec rubocop -a --only
Style/MethodCallWithArgsParentheses,Style/RescueModifier
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:1: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
parentheses for method calls with arguments.
do_something arg rescue nil
^^^^^^^^^^^^^^^^
example.rb:1:1: C: [Corrected] Style/RescueModifier: Avoid using rescue
in its modifier form.
do_something arg rescue nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 2 offenses detected, 2 offenses corrected
```

## Before

Auto-corrected to invalid syntax.

```ruby
% cat example.rb
begin
  do_something(arg
rescue
  nil
end)

% ruby -c example.rb
example.rb:3: syntax error, unexpected `rescue', expecting ')'
rescue
example.rb:5: syntax error, unexpected ')', expecting end-of-input
```

## After

Auto-corrected to valid syntax.

```ruby
% cat example.rb
begin
  do_something(arg)
rescue
  nil
end
```
@bbatsov bbatsov merged commit cd3db12 into rubocop:master Apr 20, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 20, 2021

Thanks!

@koic koic deleted the fix_incorrect_autocorrect_for_style_method_call_with_args_parentheses branch April 20, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants