Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9707] Fix false positive for Style/MethodCallWithArgsParentheses with omit_parentheses style on an endless defs node #9708

Merged
merged 1 commit into from Apr 18, 2021

Conversation

dvandersluis
Copy link
Member

Fixes #9707.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…rentheses` with `omit_parentheses` style on an endless `defs` node.
@koic koic merged commit 00dc817 into rubocop:master Apr 18, 2021
@koic
Copy link
Member

koic commented Apr 18, 2021

Thanks!

@dvandersluis dvandersluis deleted the issue/9707 branch April 18, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/MethodCallWithArgsParentheses doesn't respect endless class method parethensis
2 participants