[Fix #9257] Fix false positive for Style/SymbolProc when the block uses a variable from outside the block
#9259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… block uses a variable from outside the block.
|
The circle build passed but didn't update the PR for some reason. |
|
Looks good, thanks for this 👍 |
marcandre
reviewed
Dec 19, 2020
| (send (lvar _var) $_)) | ||
| { | ||
| (block $#symbol_proc_receiver? $(args (arg _var)) (send (lvar _var) $_)) | ||
| (numblock $#symbol_proc_receiver? $1 (send (lvar :_1) $_)) |
There was a problem hiding this comment.
I made a double take at $1! 😆
There was a problem hiding this comment.
Yeah it’s needed to balance each option in the {} but not actually used for anything (the capture for block is though so it’s needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #9127 to keep the node pattern DRY accidentally broke the check that the lvar matches the argument name.
Fixes #9257.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.