[Fix #9257] Fix false positive for Style/SymbolProc when the block …

…uses a variable from outside the block.

changelog/fix_fix_false_positive_for_stylesymbolproc.md

@@ -0,0 +1 @@
+* [#9257](https://github.com/rubocop-hq/rubocop/issues/9257): Fix false positive for `Style/SymbolProc` when the block uses a variable from outside the block. ([@dvandersluis][])

lib/rubocop/cop/style/symbol_proc.rb

@@ -22,11 +22,12 @@ class SymbolProc < Base
         SUPER_TYPES = %i[super zsuper].freeze
 
         def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)'
+        def_node_matcher :symbol_proc_receiver?, '{(send ...) (super ...) zsuper}'
         def_node_matcher :symbol_proc?, <<~PATTERN
-          ({block numblock}
-            ${(send ...) (super ...) zsuper}
-            ${(args (arg _)) 1}
-            (send (lvar _var) $_))
+          {
+            (block $#symbol_proc_receiver? $(args (arg _var)) (send (lvar _var) $_))
+            (numblock $#symbol_proc_receiver? $1 (send (lvar :_1) $_))
+          }
         PATTERN
 
         def self.autocorrect_incompatible_with

spec/rubocop/cop/style/symbol_proc_spec.rb

@@ -90,6 +90,17 @@
     expect_no_offenses('something { |x,| x.first }')
   end
 
+  it 'accepts a block with an unused argument with an method call' do
+    expect_no_offenses('something { |_x| y.call }')
+  end
+
+  it 'accepts a block with an unused argument with an lvar' do
+    expect_no_offenses(<<~RUBY)
+      y = Y.new
+      something { |_x| y.call }
+    RUBY
+  end
+
   context 'when the method has arguments' do
     it 'registers an offense' do
       expect_offense(<<~RUBY)