Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation of cop department for nested departments #9258

Merged
merged 1 commit into from Dec 20, 2020
Merged

Fix calculation of cop department for nested departments #9258

merged 1 commit into from Dec 20, 2020

Commits on Dec 19, 2020

  1. Fix calculation of cop department for nested departments 

    This fixes an issue I ran into with rubocop-i18n. This gem provides two
nested departments, I18n/RailsI18n and I18n/GetText. The intent is to
enable one and disable the other. However, disabling a department would
not disable its cops.

I tracked this issue down to how RuboCop::Config calculates a cops
department before looking at that department's configuration: It only
considers the part before the first `/`.

This commit changes this method by considering instead all parts before
the last `/`.
    @mvz
    mvz committed Dec 19, 2020
    Copy the full SHA
    aad4c7a View commit details
    Browse the repository at this point in the history